qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2 3/6] cpus: extract out kvm-specific code to accel/kvm


From: Paolo Bonzini
Subject: Re: [RFC v2 3/6] cpus: extract out kvm-specific code to accel/kvm
Date: Tue, 7 Jul 2020 19:01:38 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 07/07/20 15:58, Claudio Fontana wrote:
> +static void kvm_kick_vcpu_thread(CPUState *cpu)
> +{
> +    cpus_kick_thread(cpu);
> +}
> +

I would just use cpus_kick_thread instead of wrapping it (and likewise
would provide a global function for noop synchronization).

start_vcpu_thread is also a candidate for abstraction, so that
kvm_start_vcpu_thread(CPUState *cpu) would be just

        qemu_start_vcpu_thread(cpu, "KVM", kvm_vcpu_thread_fn);

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]