qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more sim


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar
Date: Mon, 29 Jun 2020 12:47:51 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

29.06.2020 12:36, Vladimir Sementsov-Ogievskiy wrote:
24.06.2020 19:43, Markus Armbruster wrote:
This is to make the next commit easier to review.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  util/qemu-option.c | 32 ++++++++++++++++++--------------
  1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/util/qemu-option.c b/util/qemu-option.c
index 6119f971a4..9941005c91 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -270,6 +270,7 @@ static void qemu_opt_del_all(QemuOpts *opts, const char 
*name)
  const char *qemu_opt_get(QemuOpts *opts, const char *name)
  {
      QemuOpt *opt;
+    const QemuOptDesc *desc;
Honestly, I don't see how this hunk helps with the following patch, which is 
simple anyway.
Keeping desc variable scope smaller seems better for me, as well as further 
scope of
def_val. (Still, keep my r-b if you don't want to change it).


Aha, I see, we have more similar patterns and you want them to look similarly. 
Still, it's
better to keep scope of variable smaller. May be a follow-up.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]