[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 45/46] qdev: Ignore Error objects where the return value suffices
From: |
Markus Armbruster |
Subject: |
[PATCH 45/46] qdev: Ignore Error objects where the return value suffices |
Date: |
Wed, 24 Jun 2020 18:43:43 +0200 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/core/qdev-properties.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index e1ad147339..8eb4283a56 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -653,7 +653,6 @@ static void set_pci_devfn(Object *obj, Visitor *v, const
char *name,
Property *prop = opaque;
int32_t value, *ptr = qdev_get_prop_ptr(dev, prop);
unsigned int slot, fn, n;
- Error *local_err = NULL;
char *str;
if (dev->realized) {
@@ -661,9 +660,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, const
char *name,
return;
}
- if (!visit_type_str(v, name, &str, &local_err)) {
- error_free(local_err);
- local_err = NULL;
+ if (!visit_type_str(v, name, &str, NULL)) {
if (!visit_type_int32(v, name, &value, errp)) {
return;
}
--
2.26.2
- Re: [PATCH 38/46] qom: Smooth error checking with Coccinelle, (continued)
- [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/06/24
- [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/06/24
- [PATCH 16/46] qemu-option: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/06/24
- [PATCH 28/46] block/parallels: Simplify parallels_open() after previous commit, Markus Armbruster, 2020/06/24
- [PATCH 45/46] qdev: Ignore Error objects where the return value suffices,
Markus Armbruster <=
- [PATCH 46/46] hmp: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/06/24
- [PATCH 32/46] qom: Rename qdev_get_type() to object_get_type(), Markus Armbruster, 2020/06/24
- [PATCH 21/46] hmp: Eliminate a variable in hmp_migrate_set_parameter(), Markus Armbruster, 2020/06/24
- [PATCH 29/46] acpi: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/06/24