[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods
|
From: |
P J P |
|
Subject: |
Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods |
|
Date: |
Thu, 25 Jun 2020 16:54:05 +0530 (IST) |
+-- On Thu, 25 Jun 2020, Philippe Mathieu-Daudé wrote --+
| On 6/25/20 11:18 AM, P J P wrote:
| > | g_assert_not_reached();
| >
| > This will likely be called in tz_ppc_dummy_accepts() above. Do we still
| > want to revise this patch? considering read/write callbacks are
| > unreachable.
|
| So a simple comment in each read/write might be sufficient (removing the
| qemu_log_mask calls).
Okay. Will wait for other reviews, before sending a revised series v3. Hope
that's okay.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D
- [PATCH v2 3/9] vfio: add quirk device write method, (continued)
[PATCH v2 4/9] prep: add ppc-parity write method, P J P, 2020/06/24
[PATCH v2 5/9] nvram: add nrf51_soc flash read method, P J P, 2020/06/24