Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods

[P J P]

+-- On Thu, 25 Jun 2020, Philippe Mathieu-Daudé wrote --+
| > @@ -196,7 +196,22 @@ static bool tz_ppc_dummy_accepts(void *opaque, hwaddr 
addr,
| >      g_assert_not_reached();
| 
| This is a shame we now have to fill the read/write handlers for
| unreachable code :( 
|
| > +static uint64_t tz_ppc_dummy_read(void *opaque, hwaddr addr, unsigned size)
| 
| I'd instead use a clearer:
|        g_assert_not_reached();
| 
| > +static void tz_ppc_dummy_write(void *opaque, hwaddr addr,
| 
| Ditto:
|        g_assert_not_reached();

This will likely be called in tz_ppc_dummy_accepts() above. Do we still want 
to revise this patch? considering read/write callbacks are unreachable.

Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E B54C 486B C6EB 271E E285 8B5A F050 DE8D