Re: [PATCH v3 0/3] Add Scripts for Finding Top 25 Executed Functions

[Aleksandar Markovic]

сре, 24. јун 2020. у 17:31 Ahmed Karaman
<ahmedkhaledkaraman@gmail.com> је написао/ла:
>
> Greetings,
>
> As a part of the TCG Continous Benchmarking project for GSoC this
> year, detailed reports discussing different performance measurement
> methodologies and analysis results will be sent here on the mailing
> list.
>
> The project's first report is currently being revised and will be
> posted on the mailing list in the next few days.*

Yes, I said that for each series v2, v3, v4 must contain you must
carry the same cover letter. But I didn't mean literally the same - I
didn't mean "identical".

The cover letter should always reflect the content, and should always
be a stand-alone letter, independent on previous version, but it can
change in some details, as the series or cicrcumstance change.

So, here, you should replace:

> The project's first report is currently being revised and will be
> posted on the mailing list in the next few days.*

With:

"Report 1 was published on the mailing list on the 22nd of June:

<insert here the link to the corresponding mailing list item>
"

> A section in this report will deal with measuring the top 25 executed
> functions when running QEMU. It includes two Python scripts that
> automatically perform this task.
>
> This series adds these two scripts to a new performance directory
> created under the scripts directory. It also adds a new
> "Miscellaneous" section to the end of the MAINTAINERS file with a
> "Performance Tools and Tests" subsection.
>
> Previous version of the series:
> https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg06147.html
>
> *UPDATE: Report 1 was published on the mailing list on Monday the 22nd
> of June.
>
> Best regards,
> Ahmed Karaman
>
> v2->v3:
> - Use a clearer "Syntax" and "Example of usage" in the script comment
>   and commit message.
> - Manually specify the instructions required to run Perf instead of
>   relying on the stderr produced by Perf.
> - Use more descriptive variable names.
>

History must be a complete history, not only "diff" to the previous
version. So, for v4, you should have something like this:

v3->v4:
   <you describe here difference between v3 and v4>

v2->v3:
   <you describe here difference between v2 and v3>

v1->v2:
   <you describe here difference between v1 and v2>

Thanks,
Aleksandar

> Ahmed Karaman (3):
>   scripts/performance: Add topN_perf.py script
>   scripts/performance: Add topN_callgrind.py script
>   MAINTAINERS: Add 'Performance Tools and Tests' subsection
>
>  MAINTAINERS                           |   7 ++
>  scripts/performance/topN_callgrind.py | 139 +++++++++++++++++++++++++
>  scripts/performance/topN_perf.py      | 142 ++++++++++++++++++++++++++
>  3 files changed, 288 insertions(+)
>  create mode 100755 scripts/performance/topN_callgrind.py
>  create mode 100755 scripts/performance/topN_perf.py
>
> --
> 2.17.1
>