qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwid


From: Thomas Huth
Subject: Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"
Date: Tue, 23 Jun 2020 19:07:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 23/06/2020 17.39, Philippe Mathieu-Daudé wrote:
> On 6/23/20 4:56 PM, Michael S. Tsirkin wrote:
>> This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge 
>> initial bandwidth")
>> since that change makes unit tests much slower for all developers, while 
>> it's not
>> a robust way to fix migration tests. Migration tests need to find
>> a more robust way to discover a reasonable bandwidth without slowing
>> things down for everyone.
> 
> Please also mention we can do this since 1de8e4c4dcf which allow
> marked the s390x job as "unstable" and allow it to fail.
> 
> But if nobody is going to look at it, instead lets disable
> it until someone figure out the issue:
> 
> -- >8 --
> diff --git a/.travis.yml b/.travis.yml
> index 74158f741b..364e67b14b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -507,6 +507,7 @@ jobs:
> 
>      - name: "[s390x] Clang (disable-tcg)"
>        arch: s390x
> +      if: false # Temporarily disabled due to issue testing migration
> (see commit 6d1da867e65).
>        dist: bionic
>        compiler: clang
>        addons:

Sorry, but that looks wrong. First, the disable-tcg test does not run
the qtests at all. So this is certainly the wrong location here. Second,
if just one of the qtests is failing, please only disable that single
failing qtest and not the whole test pipeline.

 Thanks,
  Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]