Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"

[Philippe Mathieu-Daudé]

On 6/23/20 4:56 PM, Michael S. Tsirkin wrote:
> This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge 
> initial bandwidth")
> since that change makes unit tests much slower for all developers, while it's 
> not
> a robust way to fix migration tests. Migration tests need to find
> a more robust way to discover a reasonable bandwidth without slowing
> things down for everyone.

Please also mention we can do this since 1de8e4c4dcf which allow
marked the s390x job as "unstable" and allow it to fail.

But if nobody is going to look at it, instead lets disable
it until someone figure out the issue:

-- >8 --
diff --git a/.travis.yml b/.travis.yml
index 74158f741b..364e67b14b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -507,6 +507,7 @@ jobs:

     - name: "[s390x] Clang (disable-tcg)"
       arch: s390x
+      if: false # Temporarily disabled due to issue testing migration
(see commit 6d1da867e65).
       dist: bionic
       compiler: clang
       addons:
---

With the hunk amended (no need to mention 1de8e4c4d actually):
Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ---
>  tests/qtest/migration-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index dc3490c9fa..21ea5ba1d2 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
>       * without throttling.
>       */
>      migrate_set_parameter_int(from, "downtime-limit", 1);
> -    migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s */
> +    migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s 
> */
>  
>      /* To check remaining size after precopy */
>      migrate_set_capability(from, "pause-before-switchover", true);
>