[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directo
From: |
Thomas Huth |
Subject: |
Re: [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directory |
Date: |
Thu, 11 Jun 2020 14:05:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 11/06/2020 14.00, Stefan Berger wrote:
> On 6/10/20 4:02 PM, Philippe Mathieu-Daudé wrote:
>> TPM subsytem is split into backends (see commit f4ede81eed2)
>> and frontends (see i.e. 3676bc69b35). Keep the emulated
>> hardware 'frontends' under hw/tpm/, but move the backends
>> in the backends/ directory.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> RFC due to a FIXME in tpm_tis_common.c, it uses
>> TRACE_TPM_UTIL_SHOW_BUFFER which is now generated
>> by backends/trace-events...
>> ---
>> Makefile | 2 +-
>> {hw/tpm => backends}/tpm_int.h | 6 ++---
>> {hw/tpm => backends}/tpm_ioctl.h | 0
>> {hw/tpm => backends}/tpm_emulator.c | 0
>> {hw/tpm => backends}/tpm_passthrough.c | 0
>> {hw/tpm => backends}/tpm_util.c | 0
>
> I don't understand this move. Why not keep everything TPM related in one
> directory even though there may be a backend directory where 'nothing
> else fits but the name.' All we need to remember is that 'emulator' and
> 'passthrough' are the backends.
We try to have a clean separation between frontends and backends in
QEMU. The concepts have been mixed in the past (see e.g. the -drive
parameter) and that led only to confusion and trouble later. The hw/
directory is clearly for emulated hardware device frontends only, we
should not include any backend code here.
Thomas
- [PATCH 4/8] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion, (continued)
- [PATCH 4/8] hw/tpm: Remove unnecessary 'tpm_int.h' header inclusion, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH 5/8] hw/tpm: Move few declarations from 'tpm_util.h' to 'tpm_int.h', Philippe Mathieu-Daudé, 2020/06/10
- [PATCH 6/8] hw/tpm: Move DEFINE_PROP_TPMBE() macro to 'tmp_prop.h' local header, Philippe Mathieu-Daudé, 2020/06/10
- [PATCH 7/8] hw/tpm: Make 'tpm_util.h' publicly accessible as "sysemu/tpm_util.h", Philippe Mathieu-Daudé, 2020/06/10
- [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directory, Philippe Mathieu-Daudé, 2020/06/10
- Re: [PATCH 0/8] tpm: Split hw/ vs backends/, Marc-André Lureau, 2020/06/10
- Re: [PATCH 0/8] tpm: Split hw/ vs backends/, Philippe Mathieu-Daudé, 2020/06/10
- Re: [PATCH 0/8] tpm: Split hw/ vs backends/, no-reply, 2020/06/10
- Re: [PATCH 0/8] tpm: Split hw/ vs backends/, no-reply, 2020/06/10