qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directo


From: Stefan Berger
Subject: Re: [RFC PATCH 8/8] tpm: Move backend code under the 'backends/' directory
Date: Thu, 11 Jun 2020 08:00:51 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 6/10/20 4:02 PM, Philippe Mathieu-Daudé wrote:
TPM subsytem is split into backends (see commit f4ede81eed2)
and frontends (see i.e. 3676bc69b35). Keep the emulated
hardware 'frontends' under hw/tpm/, but move the backends
in the backends/ directory.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
RFC due to a FIXME in tpm_tis_common.c, it uses
TRACE_TPM_UTIL_SHOW_BUFFER which is now generated
by backends/trace-events...
---
  Makefile                               |  2 +-
  {hw/tpm => backends}/tpm_int.h         |  6 ++---
  {hw/tpm => backends}/tpm_ioctl.h       |  0
  {hw/tpm => backends}/tpm_emulator.c    |  0
  {hw/tpm => backends}/tpm_passthrough.c |  0
  {hw/tpm => backends}/tpm_util.c        |  0

I don't understand this move. Why not keep everything TPM related in one directory even though there may be a backend directory where 'nothing else fits but the name.' All we need to remember is that 'emulator' and 'passthrough' are the backends.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]