qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operation


From: Richard Henderson
Subject: Re: [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operations
Date: Sat, 6 Jun 2020 12:16:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/5/20 12:02 PM, Joseph Myers wrote:
> The x87 fprem1 emulation is currently based around conversion to
> double, which is inherently unsuitable for a good emulation of any
> floatx80 operation.  Reimplement using the soft-float floatx80
> remainder operations.
> 
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> ---
>  target/i386/fpu_helper.c | 96 +++++++++++++++++++---------------------
>  1 file changed, 45 insertions(+), 51 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I would merge patch 7 into this one; I don't see value in keeping them separate.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]