qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 r


From: Richard Henderson
Subject: Re: [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder
Date: Sat, 6 Jun 2020 12:08:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/5/20 12:00 PM, Joseph Myers wrote:
> The floatx80 remainder implementation sometimes returns the numerator
> unchanged when the denominator is sufficiently larger than the
> numerator.  But if the value to be returned unchanged is a
> pseudo-denormal, that is incorrect.  Fix it to normalize the numerator
> in that case.
> 
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>


> +        if (aExp == 0 && aSig0 >> 63) {
> +            /* Pseudo-denormal argument must be returned in normalized
> +             * form.  */
> +            return packFloatx80(aSign, 1, aSig0);

We're now standardizing on

    /*
     * muli-line
     * comment
     */

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]