[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 r
From: |
Richard Henderson |
Subject: |
Re: [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder |
Date: |
Sat, 6 Jun 2020 12:08:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/5/20 12:00 PM, Joseph Myers wrote:
> The floatx80 remainder implementation sometimes returns the numerator
> unchanged when the denominator is sufficiently larger than the
> numerator. But if the value to be returned unchanged is a
> pseudo-denormal, that is incorrect. Fix it to normalize the numerator
> in that case.
>
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> + if (aExp == 0 && aSig0 >> 63) {
> + /* Pseudo-denormal argument must be returned in normalized
> + * form. */
> + return packFloatx80(aSign, 1, aSig0);
We're now standardizing on
/*
* muli-line
* comment
*/
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH 0/7] softfloat, target/i386: fprem, fprem1 fixes, Joseph Myers, 2020/06/05
- [PATCH 1/7] softfloat: merge floatx80_mod and floatx80_rem, Joseph Myers, 2020/06/05
- [PATCH 2/7] softfloat: fix floatx80 remainder pseudo-denormal check for zero, Joseph Myers, 2020/06/05
- [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder, Joseph Myers, 2020/06/05
- Re: [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder,
Richard Henderson <=
- [PATCH 4/7] softfloat: do not set denominator high bit for floatx80 remainder, Joseph Myers, 2020/06/05
- [PATCH 5/7] softfloat: return low bits of quotient from floatx80_modrem, Joseph Myers, 2020/06/05
- [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operations, Joseph Myers, 2020/06/05
- [PATCH 7/7] target/i386: reimplement fprem using floatx80 operations, Joseph Myers, 2020/06/05