Re: [PATCH] checkpatch: reversed logic with acpi test checks

[Peter Maydell]

On Thu, 4 Jun 2020 at 20:09, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote:
> > On 02/06/20 07:36, Michael S. Tsirkin wrote:

> > > +   } elsif (not $name =~ 
> > > m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> > >             $$acpi_nontestexpected = $name;
> > >     }
> > >     if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
> > >
> >
> > Queued with "!~" to achieve the logical not.
> >
> > Paolo
>
> Hmm perl manual says "not" is the logical not. Weird.
> What's !~? My perl is a bit rusty :)

man perlop says:
# Binary "!~" is just like "=~" except the return value is negated in
the logical sense.

So it's more idiomatic to use it directly rather than using =~ and then
doing a logical negation separately.

thanks
-- PMM