[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] checkpatch: reversed logic with acpi test checks
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] checkpatch: reversed logic with acpi test checks |
|
Date: |
Tue, 2 Jun 2020 09:40:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/2/20 7:36 AM, Michael S. Tsirkin wrote:
> Logic reversed: allowed list should just be ignored. Instead we
> only take that into account :(
>
> Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list")
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 0ba213e9f2..55aa45dc16 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1267,7 +1267,7 @@ sub checkfilename {
> # files and when changing tests.
> if ($name =~ m#^tests/data/acpi/# and not $name =~ m#^\.sh$#) {
> $$acpi_testexpected = $name;
> - } elsif ($name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#) {
> + } elsif (not $name =~ m#^tests/qtest/bios-tables-test-allowed-diff.h$#)
> {
> $$acpi_nontestexpected = $name;
> }
> if (defined $$acpi_testexpected and defined $$acpi_nontestexpected) {
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>