[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 03/32] python//machine.py: remove bare except
|
From: |
John Snow |
|
Subject: |
Re: [PATCH RFC 03/32] python//machine.py: remove bare except |
|
Date: |
Tue, 2 Jun 2020 12:47:06 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/2/20 7:01 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 07:53 hat John Snow geschrieben:
>> Catch only the timeout error; if there are other problems, allow the
>> stack trace to be visible.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> Having a visible stack trace is nice, but don't we still want to kill
> the qemu process to be sure that it's gone even though we can't wait for
> it to be shut down cleanly?
>
> Kevin
>
Ah, yes. I should kill and re-raise. I think Vladimir checked in some
code here recently that kept this patch from applying, so I'll have to
re-tune it anyway.
Thanks for the spot.
--js