Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Philippe Mathieu-Daudé]

On 6/2/20 9:23 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> I don't have much clue about the Renesas hardware, but at least
>> I know now the source files a little bit, so I volunteer to pick
>> up patches and send pull-requests for them during my scarce
>> hobbyist time, until someone else with more knowledge steps up
>> to do this job instead.
>>
>> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 15 +++++++++++++--
>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 0944d9c731..cbba3ac757 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  S: Odd Fixes
>>  F: target/sh4/
>> -F: hw/sh4/
>>  F: disas/sh4.c
>> -F: include/hw/sh4/
>>  
>>  SPARC TCG CPUs
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>>  F: pc-bios/u-boot-sam460ex-20100605.bin
>>  F: roms/u-boot-sam460ex
>>  
>> +Renesas Hardware
>> +----------------
>> +SH4 Hardware
>> +M: Aurelien Jarno <aurelien@aurel32.net>
>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> +S: Odd Fixes
>> +F: hw/sh4/
>> +F: hw/char/sh_serial.c
>> +F: hw/intc/sh_intc.c
>> +F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/
>> +
>>  SH4 Machines
>>  ------------
>>  R2D
>> @@ -1246,6 +1256,7 @@ S: Maintained
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh_intc.h
>>  
>>  Shix
>>  M: Magnus Damm <magnus.damm@gmail.com>
> 
> hw/sh4 include/hw/sh4/ is Aurelien's "SH4 TCG CPUs" less target/sh4
> disas/sh4.c.  Aurelien is fine with this overlap, so no problem.

See the History, generic coverage in SVN commit b6f97c14f59, then commit
fd5d5c566af keep all under target-sh4/, in ddb13561ac4 Aurelien steps
in, 2c9b7d1ab4e degraded to odd-fixes, the in fcf5ef2ab52 Thomas Huth
split hw/ VS target/.

I can read datasheets, so I am confident I can keep an eye to the
hardware and avoid its code to bitrot, highlighting I can only spend
humble hobby time on this.

I have less interest in the TCG code, so I prefer not touch it (thus,
left to Aurelien).

> 
> hw/sh4/r2d.c hw/sh4/shix.c hw/intc/sh_intc.c hw/timer/sh_timer.c overlap
> with "R2D" and "Shix".  You pointed out that Magnus hasn't been active
> in years.  Having MAINTAINERS claim him even as "odd fixer" is
> misleading then.  Have we tried to contact Magnus?

Well, he is automatically Cc'ed when these files are modified, but I
haven't seen him make comment on the list.

> 
> Say we can't reach him, or he instructs us to remove him from
> MAINTAINERS.
> 
> The only parts of these two sections your new section doesn't claim is
> hw/sh4/r2d.c and hw/sh4/shix.c.  Would you be willing to serve as odd
> fixer for them, too?  Yes, I understand you don't have access to the
> hardware, but how much worse is that for these too files than for the
> remainder of hw/sh4/?

As a side note, I once told Yoshinori that Renesas SH4 and Renesas RX
were having almost identical peripheral cores, and he recently sent a
nice series merging both hw:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08584.html

Which is why an unique 'Renesas Hardware' entry might make sense, and I
welcome Yoshinori if he wants to maintain it.

Then SH4/RX machines would be different entries.

After that, hw/sh4/r2d.c and hw/sh4/shix.c are indeed the only files
left in hw/sh4/. I am confident I can keep them in good shape.

I still want to insist that this will be during hobbyist time, based on
best effort. If someone else has time to do this, or can even be paid by
a company to look a it, I am more than happy to let him/her takes the role.

Regards,

Phil.