Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Aleksandar Markovic]

On Mon, Jun 1, 2020 at 12:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> +Peter +Markus as neutral and experienced contributors.
>
> On 6/1/20 11:56 AM, Aleksandar Markovic wrote:
> > On Mon, Jun 1, 2020 at 11:21 AM Philippe Mathieu-Daudé <f4bug@amsat.org> 
> > wrote:
> >>
> >> I don't have much clue about the Renesas hardware, but at least
> >> I know now the source files a little bit, so I volunteer to pick
> >> up patches and send pull-requests for them during my scarce
> >> hobbyist time, until someone else with more knowledge steps up
> >> to do this job instead.
> >>
> >> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >
> > There is alive and well Renesas target maintainer that obviously has
> > the access to Renesas hardware, and I have no idea why you should
> > be the maintainer for something that you say do not have much clue,
> > while at the same time omitting the original Renesas contributor.
>
> The last time Magnus was active was more than 10years ago...
>
> commit fc8e320ef5831dc0b0d744e369537893a4379753
> Author: Magnus Damm <damm@opensource.se>
> Date:   Fri Nov 13 18:51:05 2009 +0900
>
>     fix make clean targets
>
>     This patch fixes clean in case of missing directories and
>     also adds code to distclean that removes the following files:
>      qemu-monitor.texi roms/seabios/config.mak roms/vgabios/config.mak
>
>     Signed-off-by: Magnus Damm <damm@opensource.se>
>     Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> There are SH4 patches on the list:
> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html
>
> Who is going to pick them?
>
> >
> > Scandalous.
>
> I don't understand your attitude, I'm simply trying to help everyone by
> giving time to the project, relieving overloaded maintainers. You only
> keep tracking my activity and yelling about all my contributions. What
> do you expect with all your critics? They are not very constructive and
> don't improve much the project in general.
>

You add the utter confusion to a clear thing.

"Renesas" is not the same as "sh4". We had "sh4" as a target since
forever, and now you suddenly want to change "sh4 hardware" to
"Renesas hardware"??

Today, "Renesas", as a company, is more oriented towards architectures
that are similar to "sh4", but not the same - RX architectures. I find it
surprising and interesting you don't know that, since you participated
in introduction of "RX" target. BTW, you also dictate there Yoshimoto
that to do and what not to do. Why?

Aleksandar

> Regards,
>
> Phil.
>
> >
> > Regards,
> > Aleksandar
> >
> >>  MAINTAINERS | 15 +++++++++++++--
> >>  1 file changed, 13 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 0944d9c731..cbba3ac757 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -298,9 +298,7 @@ SH4 TCG CPUs
> >>  M: Aurelien Jarno <aurelien@aurel32.net>
> >>  S: Odd Fixes
> >>  F: target/sh4/
> >> -F: hw/sh4/
> >>  F: disas/sh4.c
> >> -F: include/hw/sh4/
> >>
> >>  SPARC TCG CPUs
> >>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> >> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
> >>  F: pc-bios/u-boot-sam460ex-20100605.bin
> >>  F: roms/u-boot-sam460ex
> >>
> >> +Renesas Hardware
> >> +----------------
> >> +SH4 Hardware
> >> +M: Aurelien Jarno <aurelien@aurel32.net>
> >> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> +S: Odd Fixes
> >> +F: hw/sh4/
> >> +F: hw/char/sh_serial.c
> >> +F: hw/intc/sh_intc.c
> >> +F: hw/timer/sh_timer.c
> >> +F: include/hw/sh4/
> >> +
> >>  SH4 Machines
> >>  ------------
> >>  R2D
> >> @@ -1246,6 +1256,7 @@ S: Maintained
> >>  F: hw/sh4/r2d.c
> >>  F: hw/intc/sh_intc.c
> >>  F: hw/timer/sh_timer.c
> >> +F: include/hw/sh4/sh_intc.h
> >>
> >>  Shix
> >>  M: Magnus Damm <magnus.damm@gmail.com>
> >> --
> >> 2.21.3
> >>
> >>
> >