Re: [PATCH v2 1/1] target/rx: Check for page crossings in use_goto_tb()

[Richard Henderson]

On 5/31/20 6:45 AM, Ahmed Karaman wrote:
> Add the page crossings check in use_goto_tb(). If this check is not
> applied, a number of bugs may occasionally occur during target rx
> system mode emulation.
> Also, this check is needed in user mode related to emulation of system
> call mmap(). rx target does not currently support user mode, but it is
> better to prepare use_goto_tb() in that sense in advance.
> 
> Rename parameter dc of type DisasContext* to the more common name ctx,
> to keep consistency with other targets.
> 
> Add detailed comments.
> 
> Buglink: https://bugs.launchpad.net/qemu/+bug/1880763
> Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
> ---
>  target/rx/translate.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Although I note that this failure is not currently visible because RX does not
have an MMU.  So there are no page permissions to change or fail.


r~