Re: [PATCH] target/m68k: implement opcode fetoxm1

[Richard Henderson]

On 5/31/20 6:19 AM, Laurent Vivier wrote:
> Example provided in the launchpad bug fails with:
> 
>    qemu: uncaught target signal 4 (Illegal instruction) - core dumped
>    Illegal instruction (core dumped)
> 
> It appears fetoxm1 is not implemented:
> 
>    IN: expm1f
>    0x800005cc: fetoxm1x %fp2,%fp0
>    Disassembler disagrees with translator over instruction decoding
>    Please report this to qemu-devel@nongnu.org
> 
>    (gdb) x/2hx 0x800005cc
>    0x800005cc: 0xf200 0x0808
> 
> This patch adds the instruction.
> 
> Bug: https://bugs.launchpad.net/qemu/+bug/1881450
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  target/m68k/helper.h     | 1 +
>  target/m68k/fpu_helper.c | 5 +++++
>  target/m68k/translate.c  | 3 +++
>  3 files changed, 9 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~