[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/11] tests/acceptance: add base class record/replay kern
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 03/11] tests/acceptance: add base class record/replay kernel tests |
Date: |
Wed, 27 May 2020 16:20:22 +0100 |
User-agent: |
mu4e 1.5.1; emacs 28.0.50 |
Pavel Dovgalyuk <address@hidden> writes:
> This patch adds a base for testing kernel boot recording and replaying.
> Each test has the phase of recording and phase of replaying.
> Virtual machines just boot the kernel and do not interact with
> the network.
> Structure and image links for the tests are borrowed from
> boot_linux_console.py
> Testing controls the message pattern at the end of the kernel
> boot for both record and replay modes. In replay mode QEMU is also
> intended to finish the execution automatically.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
diff --git a/MAINTAINERS b/MAINTAINERS
index 47ef3139e6..e9a9ce4f66 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2497,6 +2497,7 @@ F: net/filter-replay.c
F: include/sysemu/replay.h
F: docs/replay.txt
F: stubs/replay.c
+F: tests/acceptance/replay_kernel.py
IOVA Tree
M: Peter Xu <address@hidden>
diff --git a/tests/acceptance/replay_kernel.py
b/tests/acceptance/replay_kernel.py
new file mode 100644
index 0000000000..b8b277ad2f
--- /dev/null
+++ b/tests/acceptance/replay_kernel.py
@@ -0,0 +1,57 @@
+# Record/replay test that boots a Linux kernel
+#
+# Copyright (c) 2020 ISP RAS
+#
+# Author:
+# Pavel Dovgalyuk <address@hidden>
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or
+# later. See the COPYING file in the top-level directory.
+
+import os
+import gzip
Do we actually use gzip in this test?
+
+from avocado_qemu import wait_for_console_pattern
+from avocado.utils import process
+from avocado.utils import archive
+from boot_linux_console import LinuxKernelUtils
+
+class ReplayKernel(LinuxKernelUtils):
+ """
+ Boots a Linux kernel in record mode and checks that the console
+ is operational and the kernel command line is properly passed
+ from QEMU to the kernel.
+ Then replays the same scenario and verifies, that QEMU correctly
+ terminates.
Shouldn't we be doing more to verify the replay behaved the same as the
recorded session? What happens if things go wrong? Does QEMU barf out or
just deviate from the previous run?
+ """
+
+ timeout = 90
+
+ def run_vm(self, kernel_path, kernel_command_line, console_pattern,
+ record, shift, args):
+ vm = self.get_vm()
+ vm.set_console()
+ if record:
+ mode = 'record'
+ else:
+ mode = 'replay'
+ vm.add_args('-icount', 'shift=%s,rr=%s,rrfile=%s' %
+ (shift, mode, os.path.join(self.workdir, 'replay.bin')),
+ '-kernel', kernel_path,
+ '-append', kernel_command_line,
+ '-net', 'none')
+ if args:
+ vm.add_args(*args)
+ vm.launch()
+ self.wait_for_console_pattern(console_pattern, vm)
+ if record:
+ vm.shutdown()
+ else:
+ vm.wait()
+
+ def run_rr(self, kernel_path, kernel_command_line, console_pattern,
+ shift=7, args=None):
+ self.run_vm(kernel_path, kernel_command_line, console_pattern,
+ True, shift, args)
+ self.run_vm(kernel_path, kernel_command_line, console_pattern,
+ False, shift, args)
--
Alex Bennée
[PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64, Pavel Dovgalyuk, 2020/05/27
Re: [PATCH v2 04/11] tests/acceptance: add kernel record/replay test for x86_64, Alex Bennée, 2020/05/27