Re: [PATCH v2 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse

[Alex Bennée]

Pavel Dovgalyuk <address@hidden> writes:

> This patch splits code in BootLinuxConsole class into two different
> classes to allow reusing it by record/replay tests.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
>  0 files changed
>
> diff --git a/tests/acceptance/boot_linux_console.py 
> b/tests/acceptance/boot_linux_console.py
> index c6b06a1a13..f23c5833b7 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -28,19 +28,13 @@ try:
>  except CmdNotFoundError:
>      P7ZIP_AVAILABLE = False
>  
> -class BootLinuxConsole(Test):
> -    """
> -    Boots a Linux kernel and checks that the console is operational and the
> -    kernel command line is properly passed from QEMU to the kernel
> -    """
> -
> -    timeout = 90
> -
> +class LinuxKernelUtils(Test):

I'm not super keen on the name given it is being sub-classed. Maybe:

  class LinuxKernelTest(Test):

and then:

  class BootLinuxConsole(LinuxKernelTest)

?


Otherwise:

Reviewed-by: Alex Bennée <address@hidden>

-- 
Alex Bennée