[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct()
From: |
Markus Armbruster |
Subject: |
[PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct() |
Date: |
Wed, 27 May 2020 07:59:38 +0200 |
Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API
violations" neglected to change visit_check_struct()'s Error **
argument along with the others. If visit_check_struct() failed, we'd
take the success path. Fortunately, it can't fail here:
qobject_input_check_struct() checks we consumed the whole dictionary,
and to get here, we did. Fix it anyway.
Cc: David Hildenbrand <address@hidden>
Cc: Cornelia Huck <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
---
target/s390x/cpu_models.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 8efe6ed514..2fa609bffe 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -524,7 +524,7 @@ static void cpu_model_from_info(S390CPUModel *model, const
CpuModelInfo *info,
}
}
if (!err) {
- visit_check_struct(visitor, errp);
+ visit_check_struct(visitor, &err);
}
visit_end_struct(visitor, NULL);
visit_free(visitor);
--
2.21.3
- [PULL 00/10] Error reporting patches for 2020-05-27, Markus Armbruster, 2020/05/27
- [PULL 01/10] nvdimm: Plug memory leak in uuid property setter, Markus Armbruster, 2020/05/27
- [PULL 10/10] i386: Fix x86_cpu_load_model() error API violation, Markus Armbruster, 2020/05/27
- [PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct(),
Markus Armbruster <=
- [PULL 05/10] error: Use error_reportf_err() where appropriate, Markus Armbruster, 2020/05/27
- [PULL 04/10] tests/migration: Tighten error checking, Markus Armbruster, 2020/05/27
- [PULL 06/10] mips/malta: Fix create_cps() error handling, Markus Armbruster, 2020/05/27
- [PULL 02/10] xen: Fix and improve handling of device_add usb-host errors, Markus Armbruster, 2020/05/27
- [PULL 08/10] mips/boston: Plug memory leak in boston_mach_init(), Markus Armbruster, 2020/05/27
- [PULL 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init(), Markus Armbruster, 2020/05/27
- [PULL 07/10] mips/boston: Fix boston_mach_init() error handling, Markus Armbruster, 2020/05/27
- Re: [PULL 00/10] Error reporting patches for 2020-05-27, Peter Maydell, 2020/05/28