[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/10] tests/migration: Tighten error checking
From: |
Markus Armbruster |
Subject: |
[PULL 04/10] tests/migration: Tighten error checking |
Date: |
Wed, 27 May 2020 07:59:39 +0200 |
migrate_get_socket_address() neglects to check
visit_type_SocketAddressList() failure. This smells like a leak, but
it actually will crash dereferencing @addrs. Pass &error_abort to
remove the code smell.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/qtest/migration-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 2568c9529c..dc3490c9fa 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -13,6 +13,7 @@
#include "qemu/osdep.h"
#include "libqtest.h"
+#include "qapi/error.h"
#include "qapi/qmp/qdict.h"
#include "qemu/module.h"
#include "qemu/option.h"
@@ -301,7 +302,6 @@ static char *migrate_get_socket_address(QTestState *who,
const char *parameter)
{
QDict *rsp;
char *result;
- Error *local_err = NULL;
SocketAddressList *addrs;
Visitor *iv = NULL;
QObject *object;
@@ -310,7 +310,7 @@ static char *migrate_get_socket_address(QTestState *who,
const char *parameter)
object = qdict_get(rsp, parameter);
iv = qobject_input_visitor_new(object);
- visit_type_SocketAddressList(iv, NULL, &addrs, &local_err);
+ visit_type_SocketAddressList(iv, NULL, &addrs, &error_abort);
visit_free(iv);
/* we are only using a single address */
--
2.21.3
- [PULL 00/10] Error reporting patches for 2020-05-27, Markus Armbruster, 2020/05/27
- [PULL 01/10] nvdimm: Plug memory leak in uuid property setter, Markus Armbruster, 2020/05/27
- [PULL 10/10] i386: Fix x86_cpu_load_model() error API violation, Markus Armbruster, 2020/05/27
- [PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct(), Markus Armbruster, 2020/05/27
- [PULL 05/10] error: Use error_reportf_err() where appropriate, Markus Armbruster, 2020/05/27
- [PULL 04/10] tests/migration: Tighten error checking,
Markus Armbruster <=
- [PULL 06/10] mips/malta: Fix create_cps() error handling, Markus Armbruster, 2020/05/27
- [PULL 02/10] xen: Fix and improve handling of device_add usb-host errors, Markus Armbruster, 2020/05/27
- [PULL 08/10] mips/boston: Plug memory leak in boston_mach_init(), Markus Armbruster, 2020/05/27
- [PULL 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init(), Markus Armbruster, 2020/05/27
- [PULL 07/10] mips/boston: Fix boston_mach_init() error handling, Markus Armbruster, 2020/05/27
- Re: [PULL 00/10] Error reporting patches for 2020-05-27, Peter Maydell, 2020/05/28