[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 10/74] cris: convert to helper_cpu_halted_set
From: |
Edgar E. Iglesias |
Subject: |
Re: [PATCH v9 10/74] cris: convert to helper_cpu_halted_set |
Date: |
Thu, 21 May 2020 18:45:39 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, May 21, 2020 at 12:39:07PM -0400, Robert Foley wrote:
> From: "Emilio G. Cota" <address@hidden>
>
> And fix the temp leak along the way.
>
> Cc: "Edgar E. Iglesias" <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> Signed-off-by: Robert Foley <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> target/cris/translate.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index aaa46b5bca..6c4f091b7a 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -2823,8 +2823,9 @@ static int dec_rfe_etc(CPUCRISState *env, DisasContext
> *dc)
> cris_cc_mask(dc, 0);
>
> if (dc->op2 == 15) {
> - tcg_gen_st_i32(tcg_const_i32(1), cpu_env,
> - -offsetof(CRISCPU, env) + offsetof(CPUState, halted));
> + TCGv_i32 tmp = tcg_const_i32(1);
> + gen_helper_cpu_halted_set(cpu_env, tmp);
> + tcg_temp_free_i32(tmp);
> tcg_gen_movi_tl(env_pc, dc->pc + 2);
> t_gen_raise_exception(EXCP_HLT);
> return 2;
> --
> 2.17.1
>
- [PATCH v9 01/74] cpu: convert queued work to a QSIMPLEQ, (continued)
- [PATCH v9 01/74] cpu: convert queued work to a QSIMPLEQ, Robert Foley, 2020/05/21
- [PATCH v9 02/74] cpu: rename cpu->work_mutex to cpu->lock, Robert Foley, 2020/05/21
- [PATCH v9 03/74] cpu: introduce cpu_mutex_lock/unlock, Robert Foley, 2020/05/21
- [PATCH v9 04/74] cpu: make qemu_work_cond per-cpu, Robert Foley, 2020/05/21
- [PATCH v9 05/74] cpu: move run_on_cpu to cpus-common, Robert Foley, 2020/05/21
- [PATCH v9 06/74] cpu: introduce process_queued_cpu_work_locked, Robert Foley, 2020/05/21
- [PATCH v9 07/74] cpu: make per-CPU locks an alias of the BQL in TCG rr mode, Robert Foley, 2020/05/21
- [PATCH v9 08/74] tcg-runtime: define helper_cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 09/74] ppc: convert to helper_cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 10/74] cris: convert to helper_cpu_halted_set, Robert Foley, 2020/05/21
- Re: [PATCH v9 10/74] cris: convert to helper_cpu_halted_set,
Edgar E. Iglesias <=
- [PATCH v9 12/74] m68k: convert to helper_cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 11/74] hppa: convert to helper_cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 13/74] alpha: convert to helper_cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 14/74] microblaze: convert to helper_cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 15/74] cpu: define cpu_halted helpers, Robert Foley, 2020/05/21
- [PATCH v9 16/74] tcg-runtime: convert to cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 17/74] hw/semihosting: convert to cpu_halted_set, Robert Foley, 2020/05/21
- [PATCH v9 18/74] arm: convert to cpu_halted, Robert Foley, 2020/05/21
- [PATCH v9 20/74] sh4: convert to cpu_halted, Robert Foley, 2020/05/21