Re: [PATCH v9 14/74] microblaze: convert to helper_cpu_halted_set

[Edgar E. Iglesias]

On Thu, May 21, 2020 at 12:39:11PM -0400, Robert Foley wrote:
> From: "Emilio G. Cota" <address@hidden>
> 
> Cc: "Edgar E. Iglesias" <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> Signed-off-by: Robert Foley <address@hidden>


Reviewed-by: Edgar E. Iglesias <address@hidden>


> ---
>  target/microblaze/translate.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index f6ff2591c3..c08a7f1d39 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1237,9 +1237,7 @@ static void dec_br(DisasContext *dc)
>              LOG_DIS("sleep\n");
>  
>              t_sync_flags(dc);
> -            tcg_gen_st_i32(tmp_1, cpu_env,
> -                           -offsetof(MicroBlazeCPU, env)
> -                           +offsetof(CPUState, halted));
> +            gen_helper_cpu_halted_set(cpu_env, tmp_1);
>              tcg_gen_movi_i64(cpu_SR[SR_PC], dc->pc + 4);
>              gen_helper_raise_exception(cpu_env, tmp_hlt);
>              tcg_temp_free_i32(tmp_hlt);
> -- 
> 2.17.1
>