[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RISU v2 04/17] Adjust tracefile open for write
From: |
Alex Bennée |
Subject: |
Re: [RISU v2 04/17] Adjust tracefile open for write |
Date: |
Tue, 19 May 2020 19:24:26 +0100 |
User-agent: |
mu4e 1.4.6; emacs 28.0.50 |
Richard Henderson <address@hidden> writes:
> Truncate the new output file. Rely on umask to remove
> group+other file permissions, if desired.
>
> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> risu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/risu.c b/risu.c
> index 1c66885..f404d8f 100644
> --- a/risu.c
> +++ b/risu.c
> @@ -368,7 +368,7 @@ int main(int argc, char **argv)
> comm_fd = ismaster ? STDOUT_FILENO : STDIN_FILENO;
> } else {
> if (ismaster) {
> - comm_fd = open(trace_fn, O_WRONLY | O_CREAT, S_IRWXU);
> + comm_fd = open(trace_fn, O_WRONLY | O_CREAT | O_TRUNC, 0666);
> } else {
> comm_fd = open(trace_fn, O_RDONLY);
> }
--
Alex Bennée
- [RISU v2 00/17] risu cleanups and improvements, Richard Henderson, 2020/05/18
- [RISU v2 01/17] Use bool for tracing variables, Richard Henderson, 2020/05/18
- [RISU v2 02/17] Unify master_fd and apprentice_fd to comm_fd, Richard Henderson, 2020/05/18
- [RISU v2 03/17] Hoist trace file opening, Richard Henderson, 2020/05/18
- [RISU v2 04/17] Adjust tracefile open for write, Richard Henderson, 2020/05/18
- Re: [RISU v2 04/17] Adjust tracefile open for write,
Alex Bennée <=
- [RISU v2 05/17] Use EXIT_FAILURE, EXIT_SUCCESS, Richard Henderson, 2020/05/18
- [RISU v2 06/17] Make some risu.c symbols static, Richard Henderson, 2020/05/18
- [RISU v2 07/17] Add enum RisuOp, Richard Henderson, 2020/05/18
- [RISU v2 08/17] Add enum RisuResult, Richard Henderson, 2020/05/18
- [RISU v2 09/17] Unify i/o functions and use RisuResult, Richard Henderson, 2020/05/18