[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc"
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc" |
Date: |
Tue, 19 May 2020 08:35:31 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 5/18/20 12:39 PM, BALATON Zoltan wrote:
>> On Mon, 18 May 2020, Markus Armbruster wrote:
>>> sm501_init() and ati_vga_realize() create an "i2c-ddc" device, but
>>> neglect to realize it. Affects machines sam460ex, shix, r2d, and
>>> fulong2e.
>>>
>>> I wonder how this ever worked. If the "device becomes real only on
>>> realize" thing actually works, then we've always been missing the
>>> device, yet nobody noticed.
>>>
>>> Fix by realizing it right away. Visible in "info qom-tree"; here's
>>> the change for sam460ex:
>>>
>>> /machine (sam460ex-machine)
>>> [...]
>>> /unattached (container)
>>> [...]
>>> - /device[14] (sii3112)
>>> + /device[14] (i2c-ddc)
>>> + /device[15] (sii3112)
>>> [rest of device[*] renumbered...]
>>>
>>> Fixes: 4a1f253adb45ac6019971193d5077c4d5d55886a
>>> Fixes: 4a1f253adb45ac6019971193d5077c4d5d55886a
>>
>> One of these is probably meant to be
>> c82c7336de58876862e6b4dccbda29e9240fd388
Pasto, thanks!
> :)
>
>> although I'm not sure having a Fixes tag makes sense for this commit.
>
> AFAIK the 'Fixes' tag is not well defined in QEMU.
True.
> I personally find it handy to navigate between commits in gitk, not
> having to go via unrelated commits, which is why I use it.
> Linux kernel seems to have a stricter approach, only using it for
> security bug fixes. For this QEMU uses 'Cc: qemu-stable'.
We cc: qemu-stable for show-stoppers without security impact, too.
> Do we need to clarify its use on the wiki?
If we can build rough consensus on how we want it used, yes.
[PATCH 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus, Markus Armbruster, 2020/05/18
[PATCH 20/24] riscv: Fix type of SiFive[EU]SocState, member parent_obj, Markus Armbruster, 2020/05/18