qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus


From: Fred Konrad
Subject: Re: [PATCH 21/24] sparc/leon3: Fix to put grlib,* devices on sysbus
Date: Mon, 18 May 2020 10:09:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0



Le 5/18/20 à 7:04 AM, Markus Armbruster a écrit :
leon3_generic_hw_init() creates a "grlib,ahbpnp" and a "grlib,apbpnp"
sysbus device in a way that leaves them unplugged.

Create them the common way that puts them into the main system bus.
Affects machine leon3_generic.  Visible in "info qtree":

      bus: main-system-bus
        type System
     +  dev: grlib,ahbpnp, id ""
     +    mmio 00000000fffff000/0000000000001000
     +  dev: grlib,apbpnp, id ""
     +    mmio 00000000800ff000/0000000000001000
        dev: grlib,irqmp, id ""

Cc: Fabien Chouteau <address@hidden>
Cc: KONRAD Frederic <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Cc: Artyom Tarasenko <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
  hw/sparc/leon3.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 8f024dab7b..3facb8c2ae 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -213,14 +213,14 @@ static void leon3_generic_hw_init(MachineState *machine)
      reset_info->sp    = LEON3_RAM_OFFSET + ram_size;
      qemu_register_reset(main_cpu_reset, reset_info);
- ahb_pnp = GRLIB_AHB_PNP(object_new(TYPE_GRLIB_AHB_PNP));
+    ahb_pnp = GRLIB_AHB_PNP(qdev_create(NULL, TYPE_GRLIB_AHB_PNP));
      object_property_set_bool(OBJECT(ahb_pnp), true, "realized", &error_fatal);
      sysbus_mmio_map(SYS_BUS_DEVICE(ahb_pnp), 0, LEON3_AHB_PNP_OFFSET);
      grlib_ahb_pnp_add_entry(ahb_pnp, 0, 0, GRLIB_VENDOR_GAISLER,
                              GRLIB_LEON3_DEV, GRLIB_AHB_MASTER,
                              GRLIB_CPU_AREA);
- apb_pnp = GRLIB_APB_PNP(object_new(TYPE_GRLIB_APB_PNP));
+    apb_pnp = GRLIB_APB_PNP(qdev_create(NULL, TYPE_GRLIB_APB_PNP));
      object_property_set_bool(OBJECT(apb_pnp), true, "realized", &error_fatal);
      sysbus_mmio_map(SYS_BUS_DEVICE(apb_pnp), 0, LEON3_APB_PNP_OFFSET);
      grlib_ahb_pnp_add_entry(ahb_pnp, LEON3_APB_PNP_OFFSET, 0xFFF,


Reviewed-by: KONRAD Frederic <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]