[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 24/24] qdev: Assert onboard devices all get realized properly
From: |
Markus Armbruster |
Subject: |
[PATCH 24/24] qdev: Assert onboard devices all get realized properly |
Date: |
Mon, 18 May 2020 07:04:08 +0200 |
This would have caught some of the bugs I just fixed.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/core/qdev.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 0df995eb94..fe2dea8968 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -429,6 +429,19 @@ void qdev_init_nofail(DeviceState *dev)
object_unref(OBJECT(dev));
}
+static int qdev_assert_realized_properly(Object *obj, void *opaque)
+{
+ DeviceState *dev = DEVICE(object_dynamic_cast(obj, TYPE_DEVICE));
+ DeviceClass *dc;
+
+ if (dev) {
+ dc = DEVICE_GET_CLASS(dev);
+ assert(dev->realized);
+ assert(dev->parent_bus || !dc->bus_type);
+ }
+ return 0;
+}
+
void qdev_machine_creation_done(void)
{
/*
@@ -436,6 +449,9 @@ void qdev_machine_creation_done(void)
* only create hotpluggable devices
*/
qdev_hotplug = true;
+
+ object_child_foreach_recursive(object_get_root(),
+ qdev_assert_realized_properly, NULL);
}
bool qdev_machine_modified(void)
--
2.21.1
- Re: [PATCH 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices, (continued)
- [PATCH 23/24] sd: Hide the qdev-but-not-quite thing created by sd_init(), Markus Armbruster, 2020/05/18
- [PATCH 10/24] macio: Bury unwanted "macio-gpio" devices, Markus Armbruster, 2020/05/18
- [PATCH 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus, Markus Armbruster, 2020/05/18
- [PATCH 24/24] qdev: Assert onboard devices all get realized properly,
Markus Armbruster <=
- [PATCH 22/24] qdev: Assert devices are plugged into a bus that can take them, Markus Armbruster, 2020/05/18
- [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Markus Armbruster, 2020/05/18
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Peter Maydell, 2020/05/21
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Markus Armbruster, 2020/05/25
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Paolo Bonzini, 2020/05/25
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Peter Maydell, 2020/05/25
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Markus Armbruster, 2020/05/26