[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices
From: |
Peter Maydell |
Subject: |
Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices |
Date: |
Thu, 21 May 2020 17:17:25 +0100 |
On Mon, 18 May 2020 at 06:04, Markus Armbruster <address@hidden> wrote:
>
> These devices are optional, and enabled by property "enable-bitband".
> armv7m_instance_init() creates them unconditionally, because the
> property has not been set then. armv7m_realize() realizes them only
> when the property is true. Works, although it leaves unrealized
> devices hanging around in the QOM composition tree. Affects machines
> microbit, mps2-an505, mps2-an521, musca-a, and musca-b1.
>
> Bury the unwanted devices by making armv7m_realize() unparent them.
> Visible in "info qom-tree"; here's the change for microbit:
>
> /machine (microbit-machine)
> /microbit.twi (microbit.i2c)
> /microbit.twi[0] (qemu:memory-region)
> /nrf51 (nrf51-soc)
> /armv6m (armv7m)
> /armv7m-container[0] (qemu:memory-region)
> - /bitband[0] (ARM,bitband-memory)
> - /bitband[0] (qemu:memory-region)
> - /bitband[1] (ARM,bitband-memory)
> - /bitband[0] (qemu:memory-region)
> /cpu (cortex-m0-arm-cpu)
What does "bury" mean here? To me it implies "they still
exist but we've stuck them in a hole somewhere and covered
them up", but the qom-tree delta suggests we've actually
really deleted them?
thanks
-- PMM
- [PATCH 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus, (continued)
- [PATCH 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus, Markus Armbruster, 2020/05/18
- [PATCH 24/24] qdev: Assert onboard devices all get realized properly, Markus Armbruster, 2020/05/18
- [PATCH 22/24] qdev: Assert devices are plugged into a bus that can take them, Markus Armbruster, 2020/05/18
- [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Markus Armbruster, 2020/05/18
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices,
Peter Maydell <=
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Markus Armbruster, 2020/05/25
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Paolo Bonzini, 2020/05/25
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Peter Maydell, 2020/05/25
- Re: [PATCH 06/24] armv7m: Bury unwanted "ARM,bitband-memory" devices, Markus Armbruster, 2020/05/26
[PATCH 18/24] display/sm501 display/ati: Fix to realize "i2c-ddc", Markus Armbruster, 2020/05/18