qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/10] softfloat: Name compare relation enum


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 05/10] softfloat: Name compare relation enum
Date: Sat, 16 May 2020 07:32:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 5/15/20 9:01 PM, Richard Henderson wrote:
Give the previously unnamed enum a typedef name.  Use it in the
prototypes of compare functions.  Use it to hold the results
of the compare functions.

Signed-off-by: Richard Henderson <address@hidden>
---
  include/fpu/softfloat.h         | 25 +++++++++++----------
  target/i386/ops_sse.h           |  8 +++----
  fpu/softfloat.c                 | 40 ++++++++++++++++++---------------
  target/arm/vfp_helper.c         |  2 +-
  target/hppa/op_helper.c         |  7 +++---
  target/i386/fpu_helper.c        |  8 +++----
  target/openrisc/fpu_helper.c    |  4 ++--
  target/ppc/int_helper.c         | 13 ++++++-----
  target/s390x/fpu_helper.c       | 22 +++++++++---------
  target/sparc/fop_helper.c       |  4 ++--
  target/unicore32/ucf64_helper.c |  6 ++---
  target/xtensa/fpu_helper.c      |  6 ++---
  12 files changed, 75 insertions(+), 70 deletions(-)

diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index ca75f764aa..7f84235122 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloat.h
@@ -85,12 +85,13 @@ this code that are retained.
  /*----------------------------------------------------------------------------
  | Software IEC/IEEE floating-point ordering relations
  
*----------------------------------------------------------------------------*/
-enum {
+
+typedef enum {
      float_relation_less      = -1,
      float_relation_equal     =  0,
      float_relation_greater   =  1,
      float_relation_unordered =  2
-};
+} FloatRelation;
[...]

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]