[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt |
Date: |
Tue, 5 May 2020 15:38:43 +0200 |
On Tue, 5 May 2020 13:38:42 +0200
Gerd Hoffmann <address@hidden> wrote:
> The _STA methods for COM+LPT used to reference them,
> but that isn't the case any more.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/i386/acpi-build.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 1922868f3401..765409a90eb6 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1437,15 +1437,6 @@ static void build_q35_isa_bridge(Aml *table)
> aml_append(field, aml_named_field("LPTD", 2));
^^^^
not related to this patch but it seems that above&co are also unused fields.
it was this way in Seabios and probably even earlier wherever it was copied
from.
> aml_append(dev, field);
>
> - aml_append(dev, aml_operation_region("LPCE", AML_PCI_CONFIG,
> - aml_int(0x82), 0x02));
> - /* enable bits */
> - field = aml_field("LPCE", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE);
> - aml_append(field, aml_named_field("CAEN", 1));
> - aml_append(field, aml_named_field("CBEN", 1));
> - aml_append(field, aml_named_field("LPEN", 1));
> - aml_append(dev, field);
> -
> aml_append(scope, dev);
> aml_append(table, scope);
> }
> @@ -1469,7 +1460,6 @@ static void build_piix4_isa_bridge(Aml *table)
> {
> Aml *dev;
> Aml *scope;
> - Aml *field;
>
> scope = aml_scope("_SB.PCI0");
> dev = aml_device("ISA");
> @@ -1478,19 +1468,6 @@ static void build_piix4_isa_bridge(Aml *table)
> /* PIIX PCI to ISA irq remapping */
> aml_append(dev, aml_operation_region("P40C", AML_PCI_CONFIG,
> aml_int(0x60), 0x04));
> - /* enable bits */
> - field = aml_field("^PX13.P13C", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE);
^^^ should we drop this as well as it becomes
unused?
> - /* Offset(0x5f),, 7, */
> - aml_append(field, aml_reserved_field(0x2f8));
> - aml_append(field, aml_reserved_field(7));
> - aml_append(field, aml_named_field("LPEN", 1));
> - /* Offset(0x67),, 3, */
> - aml_append(field, aml_reserved_field(0x38));
> - aml_append(field, aml_reserved_field(3));
> - aml_append(field, aml_named_field("CAEN", 1));
> - aml_append(field, aml_reserved_field(3));
> - aml_append(field, aml_named_field("CBEN", 1));
> - aml_append(dev, field);
>
> aml_append(scope, dev);
> aml_append(table, scope);
- [PATCH v4 03/13] acpi: rtc: use a single crs range, (continued)
- [PATCH v4 04/13] acpi: serial: don't use _STA method, Gerd Hoffmann, 2020/05/05
- [PATCH v4 11/13] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/05/05
- [PATCH v4 06/13] acpi: parallel: don't use _STA method, Gerd Hoffmann, 2020/05/05
- [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/05/05
- Re: [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt,
Igor Mammedov <=
- [PATCH v4 09/13] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/05/05
- [PATCH v4 10/13] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/05/05
- [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static, Gerd Hoffmann, 2020/05/05
- [PATCH v4 05/13] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/05/05
- [PATCH v4 08/13] acpi: move aml builder code for floppy device, Gerd Hoffmann, 2020/05/05
- [PATCH v4 07/13] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/05/05