[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static |
Date: |
Tue, 5 May 2020 15:39:49 +0200 |
On Tue, 5 May 2020 13:38:43 +0200
Gerd Hoffmann <address@hidden> wrote:
> acpi aml generator needs this, but it is in floppy code now
> so we can make the function static.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> include/hw/block/fdc.h | 2 --
> hw/block/fdc.c | 4 ++--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/hw/block/fdc.h b/include/hw/block/fdc.h
> index c15ff4c62315..5d71cf972268 100644
> --- a/include/hw/block/fdc.h
> +++ b/include/hw/block/fdc.h
> @@ -16,7 +16,5 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
> DriveInfo **fds, qemu_irq *fdc_tc);
>
> FloppyDriveType isa_fdc_get_drive_type(ISADevice *fdc, int i);
> -void isa_fdc_get_drive_max_chs(FloppyDriveType type,
> - uint8_t *maxc, uint8_t *maxh, uint8_t *maxs);
>
> #endif
> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index 40faa088b5f7..499a580b993c 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
> @@ -2744,8 +2744,8 @@ FloppyDriveType isa_fdc_get_drive_type(ISADevice *fdc,
> int i)
> return isa->state.drives[i].drive;
> }
>
> -void isa_fdc_get_drive_max_chs(FloppyDriveType type,
> - uint8_t *maxc, uint8_t *maxh, uint8_t *maxs)
> +static void isa_fdc_get_drive_max_chs(FloppyDriveType type, uint8_t *maxc,
> + uint8_t *maxh, uint8_t *maxs)
> {
> const FDFormat *fdf;
>
- [PATCH v4 04/13] acpi: serial: don't use _STA method, (continued)
- [PATCH v4 04/13] acpi: serial: don't use _STA method, Gerd Hoffmann, 2020/05/05
- [PATCH v4 11/13] acpi: simplify build_isa_devices_aml(), Gerd Hoffmann, 2020/05/05
- [PATCH v4 06/13] acpi: parallel: don't use _STA method, Gerd Hoffmann, 2020/05/05
- [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/05/05
- [PATCH v4 09/13] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/05/05
- [PATCH v4 10/13] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/05/05
- [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static, Gerd Hoffmann, 2020/05/05
- Re: [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static,
Igor Mammedov <=
- [PATCH v4 05/13] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/05/05
- [PATCH v4 08/13] acpi: move aml builder code for floppy device, Gerd Hoffmann, 2020/05/05
- [PATCH v4 07/13] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/05/05