qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Failing property setters + hardwired devices + -global = a bad day


From: Paolo Bonzini
Subject: Re: Failing property setters + hardwired devices + -global = a bad day
Date: Wed, 29 Apr 2020 17:39:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 29/04/20 17:28, Markus Armbruster wrote:
> When an object gets created, its memory is zeroed, and then any class
> properties with an ->init() are initialized with
> 
>     obj->init(obj, prop);
> 
> We have just one ->init():
> 
>     void object_property_init_defval(Object *obj, ObjectProperty *prop)
> 
> It initializes from ->defval using ->set().
> 
> Aside: feels overengineered, but let's move on.
> 
> For TYPE_DEVICE objects, "static" properties get initialized the same.
> 
> Aside: if I know what "static" means, I'll be hanged.

Originally these were the only properties that were part of the class
rather than the object (so, not dynamic --> static).

> I'd love to deprecate -global wholesale, but we can't as long as we
> don't have better means to configure onboard devices.  Can we deprecate
> its use with backend properties at least?

I wouldn't mind deprecating -global wholesale, leaving the global/compat
props code only for internal usage.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]