qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/17] e1000: Don't run e1000_instance_init() twice


From: Jason Wang
Subject: Re: [PATCH 10/17] e1000: Don't run e1000_instance_init() twice
Date: Wed, 29 Apr 2020 16:55:05 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0


On 2020/4/29 上午12:34, Markus Armbruster wrote:
QOM object initialization runs .instance_init() for the type and all
its supertypes; see object_init_with_type().

Both TYPE_E1000_BASE and its concrete subtypes set .instance_init() to
e1000_instance_init().  For the concrete subtypes, it duly gets run
twice.  The second run fails, but the error gets ignored (a later
commit will change that).

Remove it from the subtypes.

Cc: Jason Wang <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


Acked-by: Jason Wang <address@hidden>


---
  hw/net/e1000.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 2a69eee63f..0d2c2759e3 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -1824,7 +1824,6 @@ static void e1000_register_types(void)
          type_info.parent = TYPE_E1000_BASE;
          type_info.class_data = (void *)info;
          type_info.class_init = e1000_class_init;
-        type_info.instance_init = e1000_instance_init;
type_register(&type_info);
      }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]