Re: [PATCH 07/17] tests/check-qom-proplist: Improve iterator coverage

[Eric Blake]

On 4/28/20 11:34 AM, Markus Armbruster wrote:
> The tests' "qemu-dummy" device has only class properties.  Turn one of
> them into an instance property.  test_dummy_class_iterator() expects
> one fewer property than test_dummy_iterator().  Rewrite
> test_dummy_prop_iterator() to take expected properties as argument.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   tests/check-qom-proplist.c | 51 +++++++++++++++++++-------------------
>   1 file changed, 26 insertions(+), 25 deletions(-)

Nice way to enhance coverage.  (I wish we could get rid of instance 
properties, but as long as we still have them, testing them is good).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org