qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/17] tests/check-qom-proplist: Improve iterator coverage


From: Eric Blake
Subject: Re: [PATCH 07/17] tests/check-qom-proplist: Improve iterator coverage
Date: Tue, 28 Apr 2020 13:27:35 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 4/28/20 11:34 AM, Markus Armbruster wrote:
The tests' "qemu-dummy" device has only class properties.  Turn one of
them into an instance property.  test_dummy_class_iterator() expects
one fewer property than test_dummy_iterator().  Rewrite
test_dummy_prop_iterator() to take expected properties as argument.

Signed-off-by: Markus Armbruster <address@hidden>
---
  tests/check-qom-proplist.c | 51 +++++++++++++++++++-------------------
  1 file changed, 26 insertions(+), 25 deletions(-)


Nice way to enhance coverage. (I wish we could get rid of instance properties, but as long as we still have them, testing them is good).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]