Re: [PATCH v2 0/6] colo-compare bugfixes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/6] colo-compare bugfixes
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
c8fd681 net/colo-compare.c: Correct ordering in complete and finalize
afb6080 net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active
e4e8eed net/colo-compare.c: Only hexdump packets if tracing is enabled
1e692fb net/colo-compare.c: Fix deadlock in compare_chr_send
d91d4d9 chardev/char.c: Use qemu_co_sleep_ns if in coroutine
e436962 net/colo-compare.c: Create event_bh with the right AioContext

=== OUTPUT BEGIN ===
1/6 Checking commit e436962eefcf (net/colo-compare.c: Create event_bh with the 
right AioContext)
2/6 Checking commit d91d4d971089 (chardev/char.c: Use qemu_co_sleep_ns if in 
coroutine)
3/6 Checking commit 1e692fba8c62 (net/colo-compare.c: Fix deadlock in 
compare_chr_send)
4/6 Checking commit e4e8eed17e9f (net/colo-compare.c: Only hexdump packets if 
tracing is enabled)
5/6 Checking commit afb60809e3e5 (net/colo-compare.c, softmmu/vl.c: Check that 
colo-compare is active)
ERROR: do not initialise statics to 0 or NULL
#34: FILE: net/colo-compare.c:58:
+static bool colo_compare_active = false;

total: 1 errors, 0 warnings, 110 lines checked

Patch 5/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/6 Checking commit c8fd681b3585 (net/colo-compare.c: Correct ordering in 
complete and finalize)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden