[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/6] net/colo-compare.c: Create event_bh with the right AioCon
From: |
Lukas Straub |
Subject: |
[PATCH v2 1/6] net/colo-compare.c: Create event_bh with the right AioContext |
Date: |
Sun, 26 Apr 2020 21:25:38 +0200 |
qemu_bh_new will set the bh to be executed in the main
loop. This causes crashes as colo_compare_handle_event assumes
that it has exclusive access the queues, which are also
concurrently accessed in the iothread.
Create the bh with the AioContext of the iothread to fulfill
these assumptions and fix the crashes. This is safe, because
the bh already takes the appropriate locks.
Signed-off-by: Lukas Straub <address@hidden>
Reviewed-by: Zhang Chen <address@hidden>
Reviewed-by: Derek Su <address@hidden>
Tested-by: Derek Su <address@hidden>
---
net/colo-compare.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 10c0239f9d..1de4220fe2 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -890,6 +890,7 @@ static void colo_compare_handle_event(void *opaque)
static void colo_compare_iothread(CompareState *s)
{
+ AioContext *ctx = iothread_get_aio_context(s->iothread);
object_ref(OBJECT(s->iothread));
s->worker_context = iothread_get_g_main_context(s->iothread);
@@ -906,7 +907,7 @@ static void colo_compare_iothread(CompareState *s)
}
colo_compare_timer_init(s);
- s->event_bh = qemu_bh_new(colo_compare_handle_event, s);
+ s->event_bh = aio_bh_new(ctx, colo_compare_handle_event, s);
}
static char *compare_get_pri_indev(Object *obj, Error **errp)
--
2.20.1
pgpX1Uhi8NYAN.pgp
Description: OpenPGP digital signature
- [PATCH v2 0/6] colo-compare bugfixes, Lukas Straub, 2020/04/26
- [PATCH v2 2/6] chardev/char.c: Use qemu_co_sleep_ns if in coroutine, Lukas Straub, 2020/04/26
- [PATCH v2 1/6] net/colo-compare.c: Create event_bh with the right AioContext,
Lukas Straub <=
- [PATCH v2 4/6] net/colo-compare.c: Only hexdump packets if tracing is enabled, Lukas Straub, 2020/04/26
- [PATCH v2 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active, Lukas Straub, 2020/04/26
- [PATCH v2 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send, Lukas Straub, 2020/04/26
- [PATCH v2 6/6] net/colo-compare.c: Correct ordering in complete and finalize, Lukas Straub, 2020/04/26
- Re: [PATCH v2 0/6] colo-compare bugfixes, no-reply, 2020/04/26