[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper
From: |
Peter Xu |
Subject: |
[PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper |
Date: |
Tue, 21 Apr 2020 12:21:03 -0400 |
The helper is introduced but we've still got plenty of places that are directly
referencing the qemu_global_mutex itself. Spread the usage.
Signed-off-by: Peter Xu <address@hidden>
---
cpus.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/cpus.c b/cpus.c
index ef441bdf62..00f6e361af 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1181,7 +1181,7 @@ static void qemu_tcg_rr_wait_io_event(void)
while (all_cpu_threads_idle()) {
stop_tcg_kick_timer();
- qemu_cond_wait(first_cpu->halt_cond, &qemu_global_mutex);
+ qemu_cond_wait_iothread(first_cpu->halt_cond);
}
start_tcg_kick_timer();
@@ -1200,7 +1200,7 @@ static void qemu_wait_io_event(CPUState *cpu)
slept = true;
qemu_plugin_vcpu_idle_cb(cpu);
}
- qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
+ qemu_cond_wait_iothread(cpu->halt_cond);
}
if (slept) {
qemu_plugin_vcpu_resume_cb(cpu);
@@ -1456,7 +1456,7 @@ static void *qemu_tcg_rr_cpu_thread_fn(void *arg)
/* wait for initial kick-off after machine start */
while (first_cpu->stopped) {
- qemu_cond_wait(first_cpu->halt_cond, &qemu_global_mutex);
+ qemu_cond_wait_iothread(first_cpu->halt_cond);
/* process any pending work */
CPU_FOREACH(cpu) {
@@ -1657,7 +1657,7 @@ static void *qemu_whpx_cpu_thread_fn(void *arg)
}
}
while (cpu_thread_is_idle(cpu)) {
- qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
+ qemu_cond_wait_iothread(cpu->halt_cond);
}
qemu_wait_io_event_common(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
@@ -1877,7 +1877,7 @@ void pause_all_vcpus(void)
replay_mutex_unlock();
while (!all_vcpus_paused()) {
- qemu_cond_wait(&qemu_pause_cond, &qemu_global_mutex);
+ qemu_cond_wait_iothread(&qemu_pause_cond);
CPU_FOREACH(cpu) {
qemu_cpu_kick(cpu);
}
@@ -2087,7 +2087,7 @@ void qemu_init_vcpu(CPUState *cpu)
}
while (!cpu->created) {
- qemu_cond_wait(&qemu_cpu_cond, &qemu_global_mutex);
+ qemu_cond_wait_iothread(&qemu_cpu_cond);
}
}
--
2.24.1
- [PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2020/04/21
- [PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}(), Peter Xu, 2020/04/21
- [PATCH 2/8] memory: Don't do topology update in memory finalize(), Peter Xu, 2020/04/21
- [PATCH 4/8] cpus: Introduce qemu_cond_timedwait_iothread(), Peter Xu, 2020/04/21
- [PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper,
Peter Xu <=
- [PATCH 5/8] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2020/04/21
- [PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), Peter Xu, 2020/04/21
- [PATCH 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2020/04/21
- [PATCH 8/8] memory: Delay the transaction pop() until commit completed, Peter Xu, 2020/04/21