[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/8] memory: Don't do topology update in memory finalize()
From: |
Peter Xu |
Subject: |
[PATCH 2/8] memory: Don't do topology update in memory finalize() |
Date: |
Tue, 21 Apr 2020 12:21:02 -0400 |
Topology update could be wrongly triggered in memory region finalize() if
there's bug somewhere else. It'll be a very confusing stack when it
happens (e.g., sending KVM ioctl within the RCU thread, and we'll observe it
only until it fails!).
Instead of that, we use the push()/pop() helper to avoid memory transaction
commit, at the same time we use assertions to make sure there's no pending
updates or it's a nested transaction, so it could fail even earlier and in a
more explicit way.
Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
memory.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index e5d634d648..fea427f43f 100644
--- a/memory.c
+++ b/memory.c
@@ -171,6 +171,12 @@ struct MemoryRegionIoeventfd {
EventNotifier *e;
};
+/* Returns whether there's any pending memory updates */
+static bool memory_region_has_pending_update(void)
+{
+ return memory_region_update_pending || ioeventfd_update_pending;
+}
+
static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd *a,
MemoryRegionIoeventfd *b)
{
@@ -1730,12 +1736,25 @@ static void memory_region_finalize(Object *obj)
* and cause an infinite loop.
*/
mr->enabled = false;
- memory_region_transaction_begin();
+
+ /*
+ * Use push()/pop() instead of begin()/commit() to make sure below block
+ * won't trigger any topology update (which should never happen, but it's
+ * still a safety belt).
+ */
+ memory_region_transaction_push();
while (!QTAILQ_EMPTY(&mr->subregions)) {
MemoryRegion *subregion = QTAILQ_FIRST(&mr->subregions);
memory_region_del_subregion(mr, subregion);
}
- memory_region_transaction_commit();
+ memory_region_transaction_pop();
+
+ /*
+ * Make sure we're either in a nested transaction or there must have no
+ * pending updates due to memory_region_del_subregion() above.
+ */
+ assert(memory_region_transaction_depth ||
+ !memory_region_has_pending_update());
mr->destructor(mr);
memory_region_clear_coalescing(mr);
--
2.24.1
- [PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2020/04/21
- [PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}(), Peter Xu, 2020/04/21
- [PATCH 2/8] memory: Don't do topology update in memory finalize(),
Peter Xu <=
- [PATCH 4/8] cpus: Introduce qemu_cond_timedwait_iothread(), Peter Xu, 2020/04/21
- [PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2020/04/21
- [PATCH 5/8] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2020/04/21
- [PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), Peter Xu, 2020/04/21
- [PATCH 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2020/04/21
- [PATCH 8/8] memory: Delay the transaction pop() until commit completed, Peter Xu, 2020/04/21