[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/13] configure: Add -Werror to PIE probe
From: |
Alex Bennée |
Subject: |
[PULL 12/13] configure: Add -Werror to PIE probe |
Date: |
Tue, 7 Apr 2020 16:51:17 +0100 |
From: Richard Henderson <address@hidden>
Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons. Shows up on windows,
where the compiler complains about -fPIC.
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>
diff --git a/configure b/configure
index 22870f38672..233c671aaa9 100755
--- a/configure
+++ b/configure
@@ -2119,7 +2119,7 @@ if compile_prog "-Werror -fno-pie" "-no-pie"; then
fi
if test "$static" = "yes"; then
- if test "$pie" != "no" && compile_prog "-fPIE -DPIE" "-static-pie"; then
+ if test "$pie" != "no" && compile_prog "-Werror -fPIE -DPIE" "-static-pie";
then
QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
QEMU_LDFLAGS="-static-pie $QEMU_LDFLAGS"
pie="yes"
@@ -2132,7 +2132,7 @@ if test "$static" = "yes"; then
elif test "$pie" = "no"; then
QEMU_CFLAGS="$CFLAGS_NOPIE $QEMU_CFLAGS"
QEMU_LDFLAGS="$LDFLAGS_NOPIE $QEMU_LDFLAGS"
-elif compile_prog "-fPIE -DPIE" "-pie"; then
+elif compile_prog "-Werror -fPIE -DPIE" "-pie"; then
QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
QEMU_LDFLAGS="-pie $QEMU_LDFLAGS"
pie="yes"
--
2.20.1
- [PULL 07/13] gdbstub: fix compiler complaining, (continued)
- [PULL 07/13] gdbstub: fix compiler complaining, Alex Bennée, 2020/04/07
- [PULL 10/13] linux-user: clean-up padding on /proc/self/maps, Alex Bennée, 2020/04/07
- [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Alex Bennée, 2020/04/07
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Aleksandar Markovic, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Richard Henderson, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Aleksandar Markovic, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Peter Maydell, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Aleksandar Markovic, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Alex Bennée, 2020/04/11
[PULL 09/13] linux-user: factor out reading of /proc/self/maps, Alex Bennée, 2020/04/07
[PULL 12/13] configure: Add -Werror to PIE probe,
Alex Bennée <=
[PULL 11/13] hw/core: properly terminate loading .hex on EOF record, Alex Bennée, 2020/04/07
[PULL 13/13] tcg/i386: Fix %r12 guest_base initialization, Alex Bennée, 2020/04/07
Re: [PULL for 5.0-rc2 00/13] various fixes, Peter Maydell, 2020/04/07