[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal
From: |
Alex Bennée |
Subject: |
[PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal |
Date: |
Tue, 7 Apr 2020 16:51:13 +0100 |
From: Richard Henderson <address@hidden>
All other calls to normalize*Subnormal detect zero input before
the call -- this is the only outlier. This case can happen with
+0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of
the correct sign.
Reported-by: Coverity (CID 1421991)
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 301ce3b537b..ae6ba718540 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -5856,6 +5856,9 @@ static floatx80 addFloatx80Sigs(floatx80 a, floatx80 b,
flag zSign,
zSig1 = 0;
zSig0 = aSig + bSig;
if ( aExp == 0 ) {
+ if (zSig0 == 0) {
+ return packFloatx80(zSign, 0, 0);
+ }
normalizeFloatx80Subnormal( zSig0, &zExp, &zSig0 );
goto roundAndPack;
}
--
2.20.1
- [PULL for 5.0-rc2 00/13] various fixes, Alex Bennée, 2020/04/07
- [PULL 02/13] elf-ops: bail out if we have no function symbols, Alex Bennée, 2020/04/07
- [PULL 03/13] linux-user: protect fcntl64 with an #ifdef, Alex Bennée, 2020/04/07
- [PULL 04/13] tests/tcg: remove extraneous pasting macros, Alex Bennée, 2020/04/07
- [PULL 01/13] .github: Enable repo-lockdown bot to refuse GitHub pull requests, Alex Bennée, 2020/04/07
- [PULL 05/13] linux-user: more debug for init_guest_space, Alex Bennée, 2020/04/07
- [PULL 06/13] target/xtensa: add FIXME for translation memory leak, Alex Bennée, 2020/04/07
- [PULL 07/13] gdbstub: fix compiler complaining, Alex Bennée, 2020/04/07
- [PULL 10/13] linux-user: clean-up padding on /proc/self/maps, Alex Bennée, 2020/04/07
- [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal,
Alex Bennée <=
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Aleksandar Markovic, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Richard Henderson, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Aleksandar Markovic, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Peter Maydell, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Aleksandar Markovic, 2020/04/10
- Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Alex Bennée, 2020/04/11
[PULL 09/13] linux-user: factor out reading of /proc/self/maps, Alex Bennée, 2020/04/07
[PULL 12/13] configure: Add -Werror to PIE probe, Alex Bennée, 2020/04/07