qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 13/14] iotests: Mark verify functions as private


From: Kevin Wolf
Subject: Re: [PATCH v9 13/14] iotests: Mark verify functions as private
Date: Mon, 30 Mar 2020 18:32:48 +0200
User-agent: Mutt/1.12.1 (2019-06-15)

Am 25.03.2020 um 00:21 hat John Snow geschrieben:
> Mark the verify functions as "private" with a leading underscore, to
> discourage their use.
> 
> (Also, make pending patches not yet using the new entry points fail in a
> very obvious way.)
> 
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>

While you touch all the function signatures, would you mind adding type
hints? Without them, the hints in execute_setup_common() stay mostly
unused because they can't be checked against callers nor callees.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]