[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 09/14] iotests: limit line length to 79 chars
From: |
Max Reitz |
Subject: |
Re: [PATCH v9 09/14] iotests: limit line length to 79 chars |
Date: |
Mon, 30 Mar 2020 14:31:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 25.03.20 00:20, John Snow wrote:
> 79 is the PEP8 recommendation. This recommendation works well for
> reading patch diffs in TUI email clients.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 64 +++++++++++++++++++++++------------
> tests/qemu-iotests/pylintrc | 6 +++-
> 2 files changed, 47 insertions(+), 23 deletions(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 3a049ece5b..e12d6e533e 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
[...]
> @@ -537,11 +547,13 @@ def pause_drive(self, drive, event=None):
> self.pause_drive(drive, "write_aio")
> return
> self.qmp('human-monitor-command',
> - command_line='qemu-io %s "break %s bp_%s"' % (drive, event,
> drive))
> + command_line='qemu-io %s "break %s bp_%s"'
> + % (drive, event, drive))
>
> def resume_drive(self, drive):
> self.qmp('human-monitor-command',
> - command_line='qemu-io %s "remove_break bp_%s"' % (drive,
> drive))
> + command_line='qemu-io %s "remove_break bp_%s"'
> + % (drive, drive))
Hm. You didn’t reply on my (second, insisting) question on what stops
us from introducing a variable here (hmp_cmd = 'qemu-io %s ...' % ...;
self.qmp('human-monitor-command', command_line=hmp_cmd)).
:c
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH v9 06/14] iotests: alphabetize standard imports, (continued)
- [PATCH v9 10/14] iotests: add hmp helper with logging, John Snow, 2020/03/24
- [PATCH v9 13/14] iotests: Mark verify functions as private, John Snow, 2020/03/24
- [PATCH v9 12/14] iotest 258: use script_main, John Snow, 2020/03/24
- [PATCH v9 11/14] iotests: add script_initialize, John Snow, 2020/03/24
- [PATCH v9 14/14] iotests: use python logging for iotests.log(), John Snow, 2020/03/24