[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 7/9] KVM: Cache kvm slot dirty bitmap size
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH RFC 7/9] KVM: Cache kvm slot dirty bitmap size |
Date: |
Wed, 25 Mar 2020 18:49:49 +0000 |
User-agent: |
Mutt/1.13.3 (2020-01-12) |
* Peter Xu (address@hidden) wrote:
> Cache it too because we'll reference it more frequently in the future.
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> accel/kvm/kvm-all.c | 1 +
> include/sysemu/kvm_int.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index f81e7a644b..ea7b8f7ca5 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -548,6 +548,7 @@ static void kvm_slot_init_dirty_bitmap(KVMSlot *mem)
> hwaddr bitmap_size = ALIGN(((mem->memory_size) >> TARGET_PAGE_BITS),
> /*HOST_LONG_BITS*/ 64) / 8;
> mem->dirty_bmap = g_malloc0(bitmap_size);
> + mem->dirty_bmap_size = bitmap_size;
> }
>
> /* Sync dirty bitmap from kernel to KVMSlot.dirty_bmap */
> diff --git a/include/sysemu/kvm_int.h b/include/sysemu/kvm_int.h
> index 1a19bfef80..71c9946ecf 100644
> --- a/include/sysemu/kvm_int.h
> +++ b/include/sysemu/kvm_int.h
> @@ -23,6 +23,7 @@ typedef struct KVMSlot
> int old_flags;
> /* Dirty bitmap cache for the slot */
> unsigned long *dirty_bmap;
> + unsigned long dirty_bmap_size;
> /* Cache of the address space ID */
> int as_id;
> /* Cache of the offset in ram address space */
> --
> 2.24.1
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH RFC 7/9] KVM: Cache kvm slot dirty bitmap size,
Dr. David Alan Gilbert <=