qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH for-5.0 3/3] object-add: don't create return value if failed


From: Marc-André Lureau
Subject: [PATCH for-5.0 3/3] object-add: don't create return value if failed
Date: Wed, 25 Mar 2020 19:47:23 +0100

If object-add failed, no need to create a return value that may later
be leaked.

Signed-off-by: Marc-André Lureau <address@hidden>
---
 qom/qom-qmp-cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 435193b036..6bd137ccbf 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -287,8 +287,8 @@ void qmp_object_add(QDict *qdict, QObject **ret_data, Error 
**errp)
     visit_free(v);
     if (obj) {
         object_unref(obj);
+        *ret_data = QOBJECT(qdict_new());
     }
-    *ret_data = QOBJECT(qdict_new());
 }
 
 void qmp_object_del(const char *id, Error **errp)
-- 
2.26.0.rc2.42.g98cedd0233




reply via email to

[Prev in Thread] Current Thread [Next in Thread]