[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] block/mirror: fix use after free of local_err
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH 2/6] block/mirror: fix use after free of local_err |
|
Date: |
Wed, 25 Mar 2020 13:01:35 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 24.03.20 16:36, Vladimir Sementsov-Ogievskiy wrote:
> local_err is used again in mirror_exit_common() after
> bdrv_set_backing_hd(), so we must zero it. Otherwise try to set
> non-NULL local_err will crash.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/mirror.c | 1 +
> 1 file changed, 1 insertion(+)
Considering Dave has taken patches 4 and 5, I think it makes sense for
me to take this one now; so, thanks for the patch and the reviews,
applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci, (continued)
- Re: [PATCH 2/6] block/mirror: fix use after free of local_err,
Max Reitz <=
[PATCH 3/6] dump/win_dump: fix use after free of err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 4/6] migration/colo: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 5/6] migration/ram: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 6/6] qga/commands-posix: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24