[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/6] dump/win_dump: fix use after free of err
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH 3/6] dump/win_dump: fix use after free of err |
Date: |
Tue, 24 Mar 2020 18:36:27 +0300 |
It's possible that we'll try to set err twice (or more). It's bad, it
will crash.
Instead, use warn_report().
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
dump/win_dump.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dump/win_dump.c b/dump/win_dump.c
index eda2a48974..652c7bad99 100644
--- a/dump/win_dump.c
+++ b/dump/win_dump.c
@@ -304,13 +304,11 @@ static void restore_context(WinDumpHeader64 *h,
struct saved_context *saved_ctx)
{
int i;
- Error *err = NULL;
for (i = 0; i < h->NumberProcessors; i++) {
if (cpu_memory_rw_debug(first_cpu, saved_ctx[i].addr,
(uint8_t *)&saved_ctx[i].ctx, sizeof(WinContext), 1)) {
- error_setg(&err, "win-dump: failed to restore CPU #%d context", i);
- warn_report_err(err);
+ warn_report("win-dump: failed to restore CPU #%d context", i);
}
}
}
--
2.21.0
[PATCH 3/6] dump/win_dump: fix use after free of err,
Vladimir Sementsov-Ogievskiy <=
[PATCH 4/6] migration/colo: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 5/6] migration/ram: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24
[PATCH 6/6] qga/commands-posix: fix use after free of local_err, Vladimir Sementsov-Ogievskiy, 2020/03/24