[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 04/11] iotests: replace mutable list default args
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH v8 04/11] iotests: replace mutable list default args |
|
Date: |
Tue, 24 Mar 2020 15:35:00 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 17.03.20 01:40, John Snow wrote:
> It's bad hygiene: if we modify this list, it will be modified across all
> invocations.
>
> (Remaining bad usages are fixed in a subsequent patch which changes the
> function signature anyway.)
>
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [PATCH v8 00/11] iotests: use python logging, John Snow, 2020/03/16
- [PATCH v8 02/11] iotests: don't use 'format' for drive_add, John Snow, 2020/03/16
- [PATCH v8 03/11] iotests: ignore import warnings from pylint, John Snow, 2020/03/16
- [PATCH v8 01/11] iotests: do a light delinting, John Snow, 2020/03/16
- [PATCH v8 04/11] iotests: replace mutable list default args, John Snow, 2020/03/16
- Re: [PATCH v8 04/11] iotests: replace mutable list default args,
Max Reitz <=
- [PATCH v8 05/11] iotests: add pylintrc file, John Snow, 2020/03/16
- [PATCH v8 06/11] iotests: drop Python 3.4 compatibility code, John Snow, 2020/03/16
- [PATCH v8 09/11] iotest 258: use script_main, John Snow, 2020/03/16
- [PATCH v8 07/11] iotests: limit line length to 79 chars, John Snow, 2020/03/16