[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 02/11] iotests: don't use 'format' for drive_add
From: |
John Snow |
Subject: |
[PATCH v8 02/11] iotests: don't use 'format' for drive_add |
Date: |
Mon, 16 Mar 2020 20:40:56 -0400 |
It shadows (with a different type) the built-in format.
Use something else.
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/055 | 3 ++-
tests/qemu-iotests/iotests.py | 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055
index 82b9f5f47d..4175fff5e4 100755
--- a/tests/qemu-iotests/055
+++ b/tests/qemu-iotests/055
@@ -469,7 +469,8 @@ class TestDriveCompression(iotests.QMPTestCase):
qemu_img('create', '-f', fmt, blockdev_target_img,
str(TestDriveCompression.image_len), *args)
if attach_target:
- self.vm.add_drive(blockdev_target_img, format=fmt,
interface="none")
+ self.vm.add_drive(blockdev_target_img,
+ img_format=fmt, interface="none")
self.vm.launch()
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index c6d9ae130d..a6b2889932 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -482,21 +482,21 @@ def add_drive_raw(self, opts):
self._args.append(opts)
return self
- def add_drive(self, path, opts='', interface='virtio', format=imgfmt):
+ def add_drive(self, path, opts='', interface='virtio', img_format=imgfmt):
'''Add a virtio-blk drive to the VM'''
options = ['if=%s' % interface,
'id=drive%d' % self._num_drives]
if path is not None:
options.append('file=%s' % path)
- options.append('format=%s' % format)
+ options.append('format=%s' % img_format)
options.append('cache=%s' % cachemode)
options.append('aio=%s' % aiomode)
if opts:
options.append(opts)
- if format == 'luks' and 'key-secret' not in opts:
+ if img_format == 'luks' and 'key-secret' not in opts:
# default luks support
if luks_default_secret_object not in self._args:
self.add_object(luks_default_secret_object)
--
2.21.1
- [PATCH v8 00/11] iotests: use python logging, John Snow, 2020/03/16
- [PATCH v8 02/11] iotests: don't use 'format' for drive_add,
John Snow <=
- [PATCH v8 03/11] iotests: ignore import warnings from pylint, John Snow, 2020/03/16
- [PATCH v8 01/11] iotests: do a light delinting, John Snow, 2020/03/16
- [PATCH v8 04/11] iotests: replace mutable list default args, John Snow, 2020/03/16
- [PATCH v8 05/11] iotests: add pylintrc file, John Snow, 2020/03/16
- [PATCH v8 06/11] iotests: drop Python 3.4 compatibility code, John Snow, 2020/03/16